chore: add caching layer to dns resolved ips #3265
Conversation
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3265/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3265 +/- ##
===========================================
- Coverage 87.86% 87.83% -0.04%
===========================================
Files 556 556
Lines 29996 29939 -57
Branches 7172 7150 -22
===========================================
- Hits 26356 26296 -60
- Misses 3336 3337 +1
- Partials 304 306 +2 ☔ View full report in Codecov by Sentry. |
src/util/utils.js
Outdated
| if (ips === undefined) { | ||
| ips = await resolver.resolve4(hostname); | ||
| if (ips?.length > 0) { | ||
| dnsCache.set(hostname, ips); |
There was a problem hiding this comment.
should we consider making the cache ttl dynamic like set lower value of the ttl specified in the dns record and the DNS_CACHE_TTL env
src/util/utils.js
Outdated
| }); | ||
|
|
||
| const fetchResolvedIps = async (hostname) => { | ||
| let ips = dnsCache.get(hostname); |
There was a problem hiding this comment.
add metrics around cache hits, misses etc
|
|
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
|
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
What are the changes introduced in this PR?
Write a brief explainer on your code changes.
What is the related Linear task?
fixes DAT-466
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.